dryrun time consuming profiling #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qizhou
reviewed
Sep 25, 2023
| @@ -82,7 +82,9 @@ pub fn register_wasm_input_foreign( | |||
| context.push_public(value); | |||
| value | |||
| } else { | |||
| context.pop_private() | |||
| let value = context.pop_private(); | |||
| println!("wasm_output:{:?}", value); | |||
| @@ -43,7 +43,7 @@ impl Context { | |||
| if self.private_inputs.is_empty() { | |||
| panic!("failed to read private input, please checkout your input"); | |||
| } | |||
| self.private_inputs.remove(0) | |||
| self.private_inputs.pop().unwrap() | |||
There was a problem hiding this comment.
I guess this will break --private argument. I am not a big fan of reverse as it results in a different order than other inputs such as context_in, etc - introducing additional context for maintainer. I think a better fix is to use VecDeque.pop_front()
https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.pop_front
or you can return data.into_iter() and get the data via iter.next()
There was a problem hiding this comment.
use VecDeque instead in 326e299
qizhou
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix dry_run time consuming bug, which is caused by an O(n) operation in pop private_inputs