Skip to content

Review lodestar cli flags - #1721

Merged
yorickdowne merged 2 commits into
ethstaker:mainfrom
nflaig:review-lodestar
Feb 11, 2024
Merged

Review lodestar cli flags#1721
yorickdowne merged 2 commits into
ethstaker:mainfrom
nflaig:review-lodestar

Conversation

@nflaig

@nflaig nflaig commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

I did a quick review of Lodestar CLI flags

  • removed --force as it should no longer be required
  • updated deprecated flags

Comment thread lodestar-vc-only.yml
Comment thread lodestar.yml
@yorickdowne

Copy link
Copy Markdown
Collaborator

This will require which Lodestar version?

@nflaig

nflaig commented Jan 30, 2024

Copy link
Copy Markdown
Contributor Author

This will require which Lodestar version?

It will work with any of the more recent releases but to get the stale lockfile fix in, would have to wait for 1.15.1, we have just cut a rc for this, will be released this week.

Will mark this as ready once the release is out

@yorickdowne

Copy link
Copy Markdown
Collaborator

OK. I may want to bundle this with #1682 (Besu 14.1.2) so that I don't have to increment the Eth Docker major twice, as both are breaking changes.

@nflaig

nflaig commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

v1.15.1 has been released

@nflaig
nflaig marked this pull request as ready for review February 7, 2024 22:07
@yorickdowne

Copy link
Copy Markdown
Collaborator

Great! I’d like to hold on to this for a bit, see what ACDC says today about client releases. If I can bundle this breaking change with other breaking changes, that’d be nice. Saves me from needing to rapidly increase the version with every change.

@nflaig

nflaig commented Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

There is no rush to have this merged, the main change here is that the --force flags are removed which is just extra protection to prevent keys from being loaded twice for whatever reason. But based on how the key management in eth-docker works it is very unlikely this can happen.

@yorickdowne
yorickdowne merged commit 430a105 into ethstaker:main Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants