Skip to content

fix(op-faucet): set op.network.id label #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sigma merged 1 commit into from
Jun 17, 2025
Merged

fix(op-faucet): set op.network.id label #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/faucet/op-faucet/op_faucet_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,24 @@ def launch(
)

config = _get_config(
image,
faucet_config,
image=image,
faucet_config=faucet_config,
network_ids=[f.ChainID for f in faucets],
)
plan.add_service(service_name, config)


def _get_config(
image,
faucet_config,
network_ids,
):
"""Get the ServiceConfig for the op-faucet service.

Args:
image (str): The image to use for the op-faucet service.
faucet_config (artifact): The config artifact for the op-faucet service.
network_ids (list of str): The network IDs to use for the op-faucet service.
"""
mount_path = "/config"
cmd = [
Expand All @@ -66,8 +69,8 @@ def _get_config(
),
},
labels={
"op.kind": "faucet"
# TODO Add network IDs
"op.kind": "faucet",
"op.network.id": "-".join(network_ids),
},
files={
mount_path: faucet_config,
Expand Down
Loading