Skip to content

fix: Support multiple sequencers: Challenger labels [41/N] #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janjakubnanista merged 1 commit into from
Jun 16, 2025
Merged

fix: Support multiple sequencers: Challenger labels [41/N] #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/challenger/input_parser.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def _parse_instance(challenger_args, challenger_name, l2s_params):

challenger_params["labels"] = {
"op.kind": "challenger",
"op.network.id": ",".join([str(network_id) for network_id in network_ids]),
"op.network.id": "-".join([str(network_id) for network_id in network_ids]),
}

# Now we make sure to cover the prestate arg combinations
Expand Down
2 changes: 1 addition & 1 deletion test/challenger/input_parser_test.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_challenger_input_parser_default_args(plan):
service_name="op-challenger-challenger-1000-2000",
enabled=True,
image="us-docker.pkg.dev/oplabs-tools-artifacts/images/op-challenger:develop",
labels={"op.kind": "challenger", "op.network.id": "1000,2000"},
labels={"op.kind": "challenger", "op.network.id": "1000-2000"},
extra_params=[],
participants=[1000, 2000],
cannon_prestate_path="",
Expand Down
Loading