Skip to content

fix: Support multiple sequencers: Add missing EL/CL labels [24/N] #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janjakubnanista merged 3 commits into from
Jun 3, 2025
Merged

fix: Support multiple sequencers: Add missing EL/CL labels [24/N] #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
363b066
fix: Add missing EL/CL labels
janjakubnanista Jun 3, 2025
17bde8c
fix: Test
janjakubnanista Jun 3, 2025
5a50717
fix: Test
janjakubnanista Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/l2/participant/cl/input_parser.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def _parse(args, participant_name, network_id, registry, cl_kind):
cl_params["labels"] = {
"op.kind": cl_kind,
"op.network.id": str(network_id),
"op.network.participant.name": participant_name,
"op.cl.type": cl_params["type"],
}

Expand Down
1 change: 1 addition & 0 deletions src/l2/participant/el/input_parser.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def _parse(args, participant_name, network_id, registry, el_kind):
el_params["labels"] = {
"op.kind": el_kind,
"op.network.id": str(network_id),
"op.network.participant.name": participant_name,
"op.el.type": el_params["type"],
}

Expand Down
21 changes: 18 additions & 3 deletions test/l2/participant/cl/launcher_test.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,12 @@ def test_l2_participant_cl_launcher_hildr(plan):
)
expect.eq(
service_config.labels,
{"op.kind": "cl", "op.network.id": "2151908", "op.cl.type": "hildr"},
{
"op.kind": "cl",
"op.network.id": "2151908",
"op.network.participant.name": "node0",
"op.cl.type": "hildr",
},
)
expect.eq(
service_config.files["/network-configs"].artifact_names,
Expand Down Expand Up @@ -216,7 +221,12 @@ def test_l2_participant_cl_launcher_kona_node(plan):
)
expect.eq(
service_config.labels,
{"op.kind": "cl", "op.network.id": "2151908", "op.cl.type": "kona-node"},
{
"op.kind": "cl",
"op.network.id": "2151908",
"op.network.participant.name": "node0",
"op.cl.type": "kona-node",
},
)
expect.eq(
service_config.files["/network-configs"].artifact_names,
Expand Down Expand Up @@ -317,7 +327,12 @@ def test_l2_participant_cl_launcher_op_node(plan):
)
expect.eq(
service_config.labels,
{"op.kind": "cl", "op.network.id": "2151908", "op.cl.type": "op-node"},
{
"op.kind": "cl",
"op.network.id": "2151908",
"op.network.participant.name": "node0",
"op.cl.type": "op-node",
},
)
expect.eq(
service_config.files["/network-configs"].artifact_names,
Expand Down
35 changes: 30 additions & 5 deletions test/l2/participant/el/launcher_test.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,12 @@ def test_l2_participant_el_launcher_op_besu(plan):
)
expect.eq(
service_config.labels,
{"op.kind": "el", "op.network.id": "2151908", "op.el.type": "op-besu"},
{
"op.kind": "el",
"op.network.id": "2151908",
"op.network.participant.name": "node0",
"op.el.type": "op-besu",
},
)
expect.eq(
service_config.files["/network-configs"].artifact_names,
Expand Down Expand Up @@ -180,7 +185,12 @@ def test_l2_participant_el_launcher_op_erigon(plan):
)
expect.eq(
service_config.labels,
{"op.kind": "el", "op.network.id": "2151908", "op.el.type": "op-erigon"},
{
"op.kind": "el",
"op.network.id": "2151908",
"op.network.participant.name": "node0",
"op.el.type": "op-erigon",
},
)
expect.eq(
service_config.files["/network-configs"].artifact_names,
Expand Down Expand Up @@ -251,7 +261,12 @@ def test_l2_participant_el_launcher_op_geth(plan):
)
expect.eq(
service_config.labels,
{"op.kind": "el", "op.network.id": "2151908", "op.el.type": "op-geth"},
{
"op.kind": "el",
"op.network.id": "2151908",
"op.network.participant.name": "node0",
"op.el.type": "op-geth",
},
)
expect.eq(
service_config.files["/network-configs"].artifact_names,
Expand Down Expand Up @@ -341,7 +356,12 @@ def test_l2_participant_el_launcher_op_nethermind(plan):
)
expect.eq(
service_config.labels,
{"op.kind": "el", "op.network.id": "2151908", "op.el.type": "op-nethermind"},
{
"op.kind": "el",
"op.network.id": "2151908",
"op.network.participant.name": "node0",
"op.el.type": "op-nethermind",
},
)
expect.eq(
service_config.files["/network-configs"].artifact_names,
Expand Down Expand Up @@ -412,7 +432,12 @@ def test_l2_participant_el_launcher_op_reth(plan):
)
expect.eq(
service_config.labels,
{"op.kind": "el", "op.network.id": "2151908", "op.el.type": "op-reth"},
{
"op.kind": "el",
"op.network.id": "2151908",
"op.network.participant.name": "node0",
"op.el.type": "op-reth",
},
)
expect.eq(
service_config.files["/network-configs"].artifact_names,
Expand Down
8 changes: 8 additions & 0 deletions test/l2/participant/input_parser_test.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def test_l2_participant_input_parser_defaults(plan):
labels={
"op.kind": "cl",
"op.network.id": "1000",
"op.network.participant.name": "node0",
"op.cl.type": "op-node",
},
ports={
Expand All @@ -91,6 +92,7 @@ def test_l2_participant_input_parser_defaults(plan):
labels={
"op.kind": "cl_builder",
"op.network.id": "1000",
"op.network.participant.name": "node0",
"op.cl.type": "op-node",
},
ports={
Expand All @@ -110,6 +112,7 @@ def test_l2_participant_input_parser_defaults(plan):
labels={
"op.kind": "el",
"op.network.id": "1000",
"op.network.participant.name": "node0",
"op.el.type": "op-geth",
},
ports={
Expand All @@ -131,6 +134,7 @@ def test_l2_participant_input_parser_defaults(plan):
labels={
"op.kind": "el_builder",
"op.network.id": "1000",
"op.network.participant.name": "node0",
"op.el.type": "op-geth",
},
ports={
Expand Down Expand Up @@ -173,6 +177,7 @@ def test_l2_participant_input_parser_defaults(plan):
labels={
"op.kind": "cl",
"op.network.id": "1000",
"op.network.participant.name": "node1",
"op.cl.type": "op-node",
},
ports={
Expand All @@ -192,6 +197,7 @@ def test_l2_participant_input_parser_defaults(plan):
labels={
"op.kind": "cl_builder",
"op.network.id": "1000",
"op.network.participant.name": "node1",
"op.cl.type": "op-node",
},
ports={
Expand All @@ -211,6 +217,7 @@ def test_l2_participant_input_parser_defaults(plan):
labels={
"op.kind": "el",
"op.network.id": "1000",
"op.network.participant.name": "node1",
"op.el.type": "op-geth",
},
ports={
Expand All @@ -232,6 +239,7 @@ def test_l2_participant_input_parser_defaults(plan):
labels={
"op.kind": "el_builder",
"op.network.id": "1000",
"op.network.participant.name": "node1",
"op.el.type": "op-geth",
},
ports={
Expand Down
Loading