Skip to content

fix(proxyd): uniquify proxyd-config artifact #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sigma merged 2 commits into from
Mar 24, 2025
Merged

fix(proxyd): uniquify proxyd-config artifact #206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f624cb0
fix(proxyd): uniquify proxyd-config artifact
sigma Mar 21, 2025
e415d6f
Merge branch 'main' into sigma/fix-proxyd-artifacts
sigma Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/proxyd/proxyd_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def launch(
config_artifact_name = create_config_artifact(
plan,
config_template,
network_params,
el_contexts,
observability_helper,
)
Expand All @@ -58,7 +59,7 @@ def launch(
observability_helper,
)

service = plan.add_service("proxyd-{0}".format(network_params.network), config)
service = plan.add_service("proxyd-{0}".format(network_params.network_id), config)
service_url = util.make_service_http_url(service)

observability.register_op_service_metrics_job(
Expand All @@ -71,6 +72,7 @@ def launch(
def create_config_artifact(
plan,
config_template,
network_params,
el_contexts,
observability_helper,
):
Expand All @@ -96,7 +98,7 @@ def create_config_artifact(
{
CONFIG_FILE_NAME: config_template_and_data,
},
name="proxyd-config",
name="proxyd-config-{0}".format(network_params.network_id),
)

return config_artifact_name
Expand Down
Loading