Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for permissionless game, challenger interop support #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: adds support for permissionless game, challenger interop support #155

wants to merge 1 commit into from

Conversation

zhwrd
Copy link
Collaborator

@zhwrd zhwrd commented Feb 5, 2025 •
edited
Loading

  • refactors contract deployment intent file building to use dicts instead of awkward toml builder (serialization to toml is now ugly but will fix this soon)
  • deploy the permissionless dispute game
  • adds interop support for challenger (needed to move outside of the l2 deployment submodule)

@zhwrd zhwrd force-pushed the zhwrd/challenger-more-games branch 3 times, most recently from 41453e1 to ef729a8 Compare February 5, 2025 14:58
@zhwrd zhwrd mentioned this pull request Feb 5, 2025
Open
@zhwrd zhwrd marked this pull request as ready for review February 7, 2025 14:49
@zhwrd zhwrd force-pushed the zhwrd/challenger-more-games branch 2 times, most recently from d810302 to 56947f3 Compare February 7, 2025 14:56
@zhwrd zhwrd force-pushed the zhwrd/challenger-more-games branch from 56947f3 to 39559c6 Compare February 7, 2025 14:57
sigma
sigma approved these changes Feb 7, 2025
View reviewed changes
src/contracts/contract_deployer.star
t, k, v
)
for t, k, v in intent_updates
# zhwrd: this mess is temporary until we implement json reading for op-deployer intent file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 oh my

Do we have a ticket to track the op-deployer improvement that'll allow deleting this? :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm happy to build this right away if we need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mslipper mslipper mslipper left review comments

@sigma sigma sigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhwrd @sigma @mslipper