Closed
Conversation
barnabasbusa
previously approved these changes
Oct 4, 2024
Collaborator
|
Lets wait for this PR to be merged once this is in stable prysm image. |
Collaborator
|
Changing the default prysm img to point at latest stable instead of latest develop: #793 |
Collaborator
|
Actually, it looks like prysm stable branch is still using grpc-gateway, and latest develop uses http. You might have had some older version of the prysm image locally. |
Collaborator
|
is this pr still needed? |
Contributor
Author
|
Please keep it open for now. I just need it as reference because I think there is still a bug in the prysm config (not related to grpc). I will test in the next days and will close it once I did all testing. |
Contributor
Author
|
Closed as described here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the keymanager api feature for prysm which was not working. In detail it:
httpflags and replaces them with thegrpc-gatewayflags since all REST APIs are exposed as gateway to the general grpc protocol