Skip to content

fix: fix keymanager api for prysm#789

Closed
TobiWo wants to merge 1 commit intoethpandaops:mainfrom
TobiWo:hotfix/fix-keymanager-api-for-prysm
Closed

fix: fix keymanager api for prysm#789
TobiWo wants to merge 1 commit intoethpandaops:mainfrom
TobiWo:hotfix/fix-keymanager-api-for-prysm

Conversation

@TobiWo
Copy link
Contributor

@TobiWo TobiWo commented Oct 4, 2024

Summary

This PR fixes the keymanager api feature for prysm which was not working. In detail it:

  • delete the unknown http flags and replaces them with the grpc-gateway flags since all REST APIs are exposed as gateway to the general grpc protocol
  • deletes the unused/unnecessary grpc port for the public port exposure

barnabasbusa
barnabasbusa previously approved these changes Oct 4, 2024
@barnabasbusa
Copy link
Collaborator

barnabasbusa commented Oct 7, 2024

Lets wait for this PR to be merged once this is in stable prysm image.

@barnabasbusa
Copy link
Collaborator

Changing the default prysm img to point at latest stable instead of latest develop: #793

@barnabasbusa
Copy link
Collaborator

Actually, it looks like prysm stable branch is still using grpc-gateway, and latest develop uses http.

You might have had some older version of the prysm image locally.

@barnabasbusa
Copy link
Collaborator

is this pr still needed?
Prysm made a new stable release that does http instead of grocery.

@barnabasbusa barnabasbusa dismissed their stale review October 17, 2024 09:24

no longer needed pr

@TobiWo
Copy link
Contributor Author

TobiWo commented Oct 18, 2024

Please keep it open for now. I just need it as reference because I think there is still a bug in the prysm config (not related to grpc). I will test in the next days and will close it once I did all testing.

@TobiWo
Copy link
Contributor Author

TobiWo commented Oct 24, 2024

Closed as described here.

@TobiWo TobiWo closed this Oct 24, 2024
@TobiWo TobiWo deleted the hotfix/fix-keymanager-api-for-prysm branch October 24, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants