Skip to content

fix: remove subscribe-all-subnets lighthouse/lodestar/teku #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barnabasbusa merged 3 commits into from
Jul 15, 2024
Merged

fix: remove subscribe-all-subnets lighthouse/lodestar/teku #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12911c9
fix: remove subscribe-all-subnets lighthouse
barnabasbusa Jul 15, 2024
282d791
remove lodestar too
barnabasbusa Jul 15, 2024
b1834e7
Update teku_launcher.star
barnabasbusa Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/cl/lighthouse/lighthouse_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,6 @@ def get_beacon_config(
"--execution-endpoints=" + EXECUTION_ENGINE_ENDPOINT,
"--jwt-secrets=" + constants.JWT_MOUNT_PATH_ON_CONTAINER,
"--suggested-fee-recipient=" + constants.VALIDATING_REWARDS_ACCOUNT,
# Set per Paris' recommendation to reduce noise in the logs
"--subscribe-all-subnets",
# vvvvvvvvvvvvvvvvvvv METRICS CONFIG vvvvvvvvvvvvvvvvvvvvv
"--metrics",
"--metrics-address=0.0.0.0",
Expand Down
2 changes: 0 additions & 2 deletions src/cl/lodestar/lodestar_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,6 @@ def get_beacon_config(
"--enr.ip=" + port_publisher.nat_exit_ip,
"--enr.tcp={0}".format(discovery_port),
"--enr.udp={0}".format(discovery_port),
# Set per Pari's recommendation to reduce noise in the logs
"--subscribeAllSubnets=true",
"--jwt-secret=" + constants.JWT_MOUNT_PATH_ON_CONTAINER,
# vvvvvvvvvvvvvvvvvvv METRICS CONFIG vvvvvvvvvvvvvvvvvvvvv
"--metrics",
Expand Down
2 changes: 0 additions & 2 deletions src/cl/teku/teku_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,6 @@ def get_beacon_config(
"ARCHIVE" if constants.ARCHIVE_MODE else "PRUNE"
),
"--p2p-enabled=true",
# Set per Pari's recommendation, to reduce noise in the logs
"--p2p-subscribe-all-subnets-enabled=true",
"--p2p-peer-lower-bound={0}".format(MIN_PEERS),
"--p2p-advertised-ip=" + port_publisher.nat_exit_ip,
"--p2p-discovery-site-local-addresses-enabled=true",
Expand Down