Skip to content

fix(apache): only set static port if wanted #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barnabasbusa merged 1 commit into from
May 13, 2024
Merged

fix(apache): only set static port if wanted #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,8 +740,8 @@ xatu_sentry_params:

# Apache params
# Apache public port to port forward to local machine
# Default to port 40000, only set if apache additional service is activated
apache_port: 40000
# Default to port None, only set if apache additional service is activated
apache_port: null

# Global tolerations that will be passed to all containers (unless overridden by a more specific toleration)
# Only works with Kubernetes
Expand Down
11 changes: 7 additions & 4 deletions src/apache/apache_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,13 @@ def launch_apache(
bootstrap_info_files_artifact_name = plan.render_templates(
template_and_data_by_rel_dest_filepath, "bootstrap-info"
)

public_ports = {
HTTP_PORT_ID: shared_utils.new_port_spec(apache_port, shared_utils.TCP_PROTOCOL)
}
public_ports = {}
if apache_port != None:
public_ports = {
HTTP_PORT_ID: shared_utils.new_port_spec(
apache_port, shared_utils.TCP_PROTOCOL
)
}

config = get_config(
config_files_artifact_name,
Expand Down
2 changes: 1 addition & 1 deletion src/package_io/input_parser.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ def default_input_args():
"persistent": False,
"mev_type": None,
"xatu_sentry_enabled": False,
"apache_port": 40000,
"apache_port": None,
"global_tolerations": [],
"global_node_selectors": {},
"keymanager_enabled": False,
Expand Down