Skip to content

fix: disable full sync if gcmode is archive #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barnabasbusa merged 3 commits into from
Apr 15, 2024
Merged

fix: disable full sync if gcmode is archive #563

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc0a5f6
fix: disable full sync if gcmode is archive
barnabasbusa Apr 15, 2024
37a13c3
fix to check for = or nothing
barnabasbusa Apr 15, 2024
238e881
fix to check for = or nothing
barnabasbusa Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/el/geth/geth_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ def get_config(
tolerations,
node_selectors,
):
if "--gcmode=archive" in extra_params or "--gcmode archive" in extra_params:
gcmode_archive = True
else:
gcmode_archive = False
# TODO: Remove this once electra fork has path based storage scheme implemented
if (
constants.NETWORK_NAME.verkle in network
Expand All @@ -217,9 +221,7 @@ def get_config(
elif constants.NETWORK_NAME.shadowfork in network:
init_datadir_cmd_str = "echo shadowfork"

elif (
"--gcmode archive" in extra_params
): # Disable path based storage scheme archive mode
elif gcmode_archive: # Disable path based storage scheme archive mode
init_datadir_cmd_str = "geth init --state.scheme=hash --datadir={0} {1}".format(
EXECUTION_DATA_DIRPATH_ON_CLIENT_CONTAINER,
constants.GENESIS_CONFIG_MOUNT_PATH_ON_CONTAINER + "/genesis.json",
Expand All @@ -236,7 +238,7 @@ def get_config(
# TODO: REMOVE Once geth default db is path based, and builder rebased
"{0}".format(
"--state.scheme=path"
if "verkle" not in network and "--gcmode archive" not in extra_params
if "verkle" not in network and not gcmode_archive
else ""
),
# Override prague fork timestamp for electra fork
Expand Down Expand Up @@ -275,7 +277,7 @@ def get_config(
"--authrpc.addr=0.0.0.0",
"--authrpc.vhosts=*",
"--authrpc.jwtsecret=" + constants.JWT_MOUNT_PATH_ON_CONTAINER,
"--syncmode=full",
"--syncmode=full" if not gcmode_archive else "--gcmode=archive",
"--rpc.allow-unprotected-txs",
"--metrics",
"--metrics.addr=0.0.0.0",
Expand Down