Conversation
TobiWo
approved these changes
Mar 29, 2024
Contributor
TobiWo
left a comment
TobiWo
left a comment
There was a problem hiding this comment.
Looks good to me although I would create new variables and not slice directly because it is more readable if you slice into a well named variable 🙂 .
Collaborator
Author
|
Fixed. @TobiWo |
parithosh
approved these changes
Apr 2, 2024
barnabasbusa
pushed a commit
that referenced
this pull request
Apr 19, 2024
🤖 I have created a release *beep* *boop* --- ## [2.2.0](2.1.0...2.2.0) (2024-04-19) ### Features * add assertoor test for per PR CI job ([#537](#537)) ([8ef5c57](8ef5c57)) * add blutgang rpc load balancer ([#569](#569)) ([1be5f95](1be5f95)) * add dugtrio beacon load balancer ([#568](#568)) ([56d2fa3](56d2fa3)) * add new assertoor test to per ci jobs ([#545](#545)) ([3005d46](3005d46)) * use new rpc snooper from `ethpandaops/rpc-snooper` ([#567](#567)) ([5676f0d](5676f0d)) ### Bug Fixes * add --contract-deployment-block parameter for Prysm ([#557](#557)) ([d8dfbae](d8dfbae)) * Added '--enable-private-discovery' to Grandine ([#541](#541)) ([a1ae708](a1ae708)) * beaconchain explorer ([#531](#531)) ([b62ed6f](b62ed6f)) * beaconchain explorer ([#538](#538)) ([ce1f337](ce1f337)) * blobber incorrect url ([#528](#528)) ([6f84e3d](6f84e3d)) * bump json rpc snooper ([#553](#553)) ([f69c4a7](f69c4a7)) * disable full sync if gcmode is archive ([#563](#563)) ([b7592ec](b7592ec)) * disable pbss when gcmode archive set ([#559](#559)) ([e085462](e085462)) * disable pbss when gcmode archive set, force hash based init ([#562](#562)) ([3e1c7a6](3e1c7a6)) * disable static peers ([#529](#529)) ([c5d4028](c5d4028)) * enable single node mode on lodestar by default ([#558](#558)) ([555ad7d](555ad7d)) * fix doc string typo ([#560](#560)) ([13de3f6](13de3f6)) * fix failing persistence test ([#554](#554)) ([99242d6](99242d6)) * increase mem limit of snooper ([#546](#546)) ([6ba5770](6ba5770)) * prysm beacon http url ([#536](#536)) ([4914531](4914531)) * prysm beacon_http_url ([#535](#535)) ([ee7528c](ee7528c)) * prysm vc ([#533](#533)) ([72ddeb2](72ddeb2)) * remove un-needed prysm vc check ([#542](#542)) ([f6326fe](f6326fe)) * set application protocol to be http for rpc ([#548](#548)) ([905de7c](905de7c)) * set the correct default vc image ([#544](#544)) ([953741d](953741d)) * uniformize keymanager ([#534](#534)) ([a6a2830](a6a2830)) * update prometheus api ([#539](#539)) ([d2b9fb8](d2b9fb8)) * update vc <> cl matrix ([#564](#564)) ([0ffcf74](0ffcf74)) * update vc compatibility matrix ([#543](#543)) ([58c4684](58c4684)) * use `minimal-preset` images for dora & assertoor when minimal preset is used ([#532](#532)) ([ad7773e](ad7773e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
darigaaz86
pushed a commit
to darigaaz86/kurtosis-eth
that referenced
this pull request
Nov 12, 2025
🤖 I have created a release *beep* *boop* --- ## [2.2.0](ethpandaops/ethereum-package@2.1.0...2.2.0) (2024-04-19) ### Features * add assertoor test for per PR CI job ([#537](ethpandaops/ethereum-package#537)) ([8ef5c57](ethpandaops/ethereum-package@8ef5c57)) * add blutgang rpc load balancer ([#569](ethpandaops/ethereum-package#569)) ([1be5f95](ethpandaops/ethereum-package@1be5f95)) * add dugtrio beacon load balancer ([#568](ethpandaops/ethereum-package#568)) ([56d2fa3](ethpandaops/ethereum-package@56d2fa3)) * add new assertoor test to per ci jobs ([#545](ethpandaops/ethereum-package#545)) ([3005d46](ethpandaops/ethereum-package@3005d46)) * use new rpc snooper from `ethpandaops/rpc-snooper` ([#567](ethpandaops/ethereum-package#567)) ([5676f0d](ethpandaops/ethereum-package@5676f0d)) ### Bug Fixes * add --contract-deployment-block parameter for Prysm ([#557](ethpandaops/ethereum-package#557)) ([d8dfbae](ethpandaops/ethereum-package@d8dfbae)) * Added '--enable-private-discovery' to Grandine ([#541](ethpandaops/ethereum-package#541)) ([a1ae708](ethpandaops/ethereum-package@a1ae708)) * beaconchain explorer ([#531](ethpandaops/ethereum-package#531)) ([b62ed6f](ethpandaops/ethereum-package@b62ed6f)) * beaconchain explorer ([#538](ethpandaops/ethereum-package#538)) ([ce1f337](ethpandaops/ethereum-package@ce1f337)) * blobber incorrect url ([#528](ethpandaops/ethereum-package#528)) ([6f84e3d](ethpandaops/ethereum-package@6f84e3d)) * bump json rpc snooper ([#553](ethpandaops/ethereum-package#553)) ([f69c4a7](ethpandaops/ethereum-package@f69c4a7)) * disable full sync if gcmode is archive ([#563](ethpandaops/ethereum-package#563)) ([b7592ec](ethpandaops/ethereum-package@b7592ec)) * disable pbss when gcmode archive set ([#559](ethpandaops/ethereum-package#559)) ([e085462](ethpandaops/ethereum-package@e085462)) * disable pbss when gcmode archive set, force hash based init ([#562](ethpandaops/ethereum-package#562)) ([3e1c7a6](ethpandaops/ethereum-package@3e1c7a6)) * disable static peers ([#529](ethpandaops/ethereum-package#529)) ([c5d4028](ethpandaops/ethereum-package@c5d4028)) * enable single node mode on lodestar by default ([#558](ethpandaops/ethereum-package#558)) ([555ad7d](ethpandaops/ethereum-package@555ad7d)) * fix doc string typo ([#560](ethpandaops/ethereum-package#560)) ([13de3f6](ethpandaops/ethereum-package@13de3f6)) * fix failing persistence test ([#554](ethpandaops/ethereum-package#554)) ([99242d6](ethpandaops/ethereum-package@99242d6)) * increase mem limit of snooper ([#546](ethpandaops/ethereum-package#546)) ([6ba5770](ethpandaops/ethereum-package@6ba5770)) * prysm beacon http url ([#536](ethpandaops/ethereum-package#536)) ([4914531](ethpandaops/ethereum-package@4914531)) * prysm beacon_http_url ([#535](ethpandaops/ethereum-package#535)) ([ee7528c](ethpandaops/ethereum-package@ee7528c)) * prysm vc ([#533](ethpandaops/ethereum-package#533)) ([72ddeb2](ethpandaops/ethereum-package@72ddeb2)) * remove un-needed prysm vc check ([#542](ethpandaops/ethereum-package#542)) ([f6326fe](ethpandaops/ethereum-package@f6326fe)) * set application protocol to be http for rpc ([#548](ethpandaops/ethereum-package#548)) ([905de7c](ethpandaops/ethereum-package@905de7c)) * set the correct default vc image ([#544](ethpandaops/ethereum-package#544)) ([953741d](ethpandaops/ethereum-package@953741d)) * uniformize keymanager ([#534](ethpandaops/ethereum-package#534)) ([a6a2830](ethpandaops/ethereum-package@a6a2830)) * update prometheus api ([#539](ethpandaops/ethereum-package#539)) ([d2b9fb8](ethpandaops/ethereum-package@d2b9fb8)) * update vc <> cl matrix ([#564](ethpandaops/ethereum-package#564)) ([0ffcf74](ethpandaops/ethereum-package@0ffcf74)) * update vc compatibility matrix ([#543](ethpandaops/ethereum-package#543)) ([58c4684](ethpandaops/ethereum-package@58c4684)) * use `minimal-preset` images for dora & assertoor when minimal preset is used ([#532](ethpandaops/ethereum-package#532)) ([ad7773e](ethpandaops/ethereum-package@ad7773e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.