feat: support amsterdam time#1187
Closed
jihoonsong wants to merge 2 commits intoethpandaops:mainfrom
Closed
Conversation
Collaborator
|
What exactly do we use this for? |
Contributor
Author
|
It's used for the EL to figure out which fork it's in to determine if current engine API call is allowed. For example, BALs adds two new versions of engine APIs and Geth could use Amsterdam time to figure out if a call to those APIs is made after Gloas. |
Collaborator
|
Amserdam Time is already in genesis.json and geth should be able to read it from that, assuming you set gloas_fork_epoch. |
Contributor
Author
|
Damn, you're right. There was some different issue and I was confused with that. Sorry about this, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports Amsterdam time. Features for Glamsterdam such as BALs could use this.