Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle session and custom variable name #200

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Handle session and custom variable name #200

merged 2 commits into from
Dec 9, 2022

Conversation

kaushalrajbacancy
Copy link
Contributor

  • chain can't be set if want to allow custom chain id. Otherwise, it will take the chain id from the initialized SDK only.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

0xSulpiride
0xSulpiride approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@0xSulpiride 0xSulpiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arddluma
arddluma requested changes Dec 9, 2022
View reviewed changes
Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update example code ?

@kaushalrajbacancy
Copy link
Contributor Author

@arddluma What change does it require? I guess it should be as it is.

arddluma
arddluma approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaushalrajbacancy kaushalrajbacancy merged commit 9d717b2 into master Dec 9, 2022
@kaushalrajbacancy kaushalrajbacancy deleted the handle-session-and-custom-variable-name branch December 9, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xSulpiride 0xSulpiride 0xSulpiride approved these changes

@arddluma arddluma arddluma approved these changes

@ch4r10t33r ch4r10t33r Awaiting requested review from ch4r10t33r

@vignesha22 vignesha22 Awaiting requested review from vignesha22

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalrajbacancy @0xSulpiride @arddluma