Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

swarm/api/http: Error template restyle#735

Closed
Mistra wants to merge 2 commits into
ethersphere:swarm-network-rewritefrom
Mistra:swarm-network-rewrite
Closed

swarm/api/http: Error template restyle#735
Mistra wants to merge 2 commits into
ethersphere:swarm-network-rewritefrom
Mistra:swarm-network-rewrite

Conversation

@Mistra
Copy link
Copy Markdown

@Mistra Mistra commented Jun 20, 2018

Continuing the discussion from issue #457

screenshot

The result is more or less like this

@cobordism
Copy link
Copy Markdown

Hi. Thank you for this PR.
However you will have to reissue it to another branch.
Now that the swarm-network-rewrite is over and the master PR has been made here: ethereum/go-ethereum#17041
we will begin using master/develop branches again.

I think this will be cleared up in the coming days.

@Mistra
Copy link
Copy Markdown
Author

Mistra commented Jun 20, 2018

I see, mind keeping it open for a while? I just wanted to keep on discussing about the topic, I don't think that was going to be merged anyway.

@cobordism
Copy link
Copy Markdown

sure. we'll keep it open and use this space to talk :)

@Mistra
Copy link
Copy Markdown
Author

Mistra commented Jun 20, 2018

While we are here, a few things:

  1. I've isolated the css under a single constant but it's just a workaround to avoid a bit of copy/paste. Since the error pages are more or less all the same, wouldn't it be better to have a unique html template and pass all the needed variables through the parser? It's the first solution that came into my mind.

  2. Some titles and error subtitles are long. E.g. There was a problem serving the requested page. Mind if I try to make it more short and to the point?

  3. The style is minimal and dark. While minimal could work, maybe dark is not actually the best related to other pages like https://swarm-gateways.net/bzz:/theswarm.eth/
    Another mock was this one, maybe is more in tune.
    orange theme

@acud
Copy link
Copy Markdown
Contributor

acud commented Jun 20, 2018

@Mistra thank you for the contribution!
the first one looks great but indeed dark theme is not so user friendly

the second is really orange 😄
try to tint the background a bit? (let's say with 50% or 20% opacity)
you can hit me up on gitter and we could do a few tests together and see what works best if you have a bit of time. we could also tackle the other issues together.

@Mistra
Copy link
Copy Markdown
Author

Mistra commented Jun 28, 2018

Closing this one, I'll open a new PR after #756 is complete.

@Mistra Mistra closed this Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants