You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Hi. Thank you for this PR.
However you will have to reissue it to another branch.
Now that the swarm-network-rewrite is over and the master PR has been made here: ethereum/go-ethereum#17041
we will begin using master/develop branches again.
I think this will be cleared up in the coming days.
I've isolated the css under a single constant but it's just a workaround to avoid a bit of copy/paste. Since the error pages are more or less all the same, wouldn't it be better to have a unique html template and pass all the needed variables through the parser? It's the first solution that came into my mind.
Some titles and error subtitles are long. E.g. There was a problem serving the requested page. Mind if I try to make it more short and to the point?
The style is minimal and dark. While minimal could work, maybe dark is not actually the best related to other pages like https://swarm-gateways.net/bzz:/theswarm.eth/
Another mock was this one, maybe is more in tune.
@Mistra thank you for the contribution!
the first one looks great but indeed dark theme is not so user friendly
the second is really orange 😄
try to tint the background a bit? (let's say with 50% or 20% opacity)
you can hit me up on gitter and we could do a few tests together and see what works best if you have a bit of time. we could also tackle the other issues together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the discussion from issue #457
The result is more or less like this