This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Add tests for buffered http get#725
Merged
Merged
Conversation
acud
reviewed
Jun 18, 2018
Contributor
acud
left a comment
There was a problem hiding this comment.
@janos this generally LGTM however I have the following concerns:
- i'm not sure that this is exhaustive with the original
ioCopyBufferSize- 32kb is not that much, taking into account os caching and os native kernel reader buffer sizes. my assumption they will vary greatly in different systems under different hardware conditions. the variance in uploaded file size is also not big enough IMHO. to get a proper regression I'd aim for bigger numbers and have the test run for a longer time. - flakyness alert - you don't think this will flake quite often? are the slope values travis adjusted? i'm usually not in favour of having hardcoded relative result values running on a CI - this asks for trouble. boolean assertions are better
Member
Author
|
@justelad Thanks for the review.
Would you like to add a -longrunning variation of tests for bigger files? This sizes with slower get's are in order of magnitude that are acceptable for standard tests on Travis.
|
zelig
approved these changes
Jun 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.