This repository was archived by the owner on Aug 2, 2021. It is now read-only.
metrics: remove metrics.influxdb.accounting flag#2002
Merged
Conversation
holisticode
approved these changes
Dec 2, 2019
Contributor
|
Possibly because accounting isn't on by default yet, so someone thought it should be optional, or something like that |
janos
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After @holisticode reported that the accounting metrics were not being forwarded on one of his deployments, I discovered this flag....
I'm no sure why these were dealt differently but I suggest to remove this flag.