-
Notifications
You must be signed in to change notification settings - Fork 109
[Store] Allow parameters to be set via cli and env vars #195
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,7 +69,9 @@ func NewDefaultStoreParams() (self *StoreParams) { | |
| //this can only finally be set after all config options (file, cmd line, env vars) | ||
| //have been evaluated | ||
| func (self *StoreParams) Init(path string) { | ||
| self.ChunkDbPath = filepath.Join(path, "chunks") | ||
| if self.ChunkDbPath == "" { | ||
| self.ChunkDbPath = filepath.Join(path, "chunks") | ||
| } | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this the best way to handle this or does it make more sense to add this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is fine here.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It needs to be here because the default for a path can be overridden by command line or env var later. |
||
| } | ||
|
|
||
| // netstore contructor, takes path argument that is used to initialise dbStore, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename comment to store