This repository was archived by the owner on Aug 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 110
[DO NOT MERGE] swarm-network-rewrite merge to master #171
Closed
Closed
Changes from 2 commits
Commits
Show all changes
959 commits
Select commit
Hold shift + click to select a range
97c4b61
swarm: propagate networkid to Bzz protocol
nonsense 9a14629
swarm/network: unregister peer from Kademlia when handshake fails
nonsense 5315159
swarm/network: use OverlayAddr. remove Node.Address()
nonsense 8a67e7d
swarm/network: get rid of Unregister when Handshake fails.
nonsense bede043
swarm/pss: Add GetPeer, GetPeerAddress api method
nolash 09c3ac4
root dir bug
acud dc11bad
test pass
acud 3cf9384
test green on mac again
acud 15d7cca
and on linux
acud ac1ece2
minor refinements
acud fc3bb8d
copyright year
acud d68fa66
Merge pull request #557 from ethersphere/test-newswarm
zelig 8a0e671
core/types: avoid duplicating transactions on changing signer (#16435)
countvonzero c1f1418
core/state: cache missing storage entries (#16584)
fjl 5b77344
cmd/utils: point users to --syncmode under DEPRECATED (#16572)
martinklepsch ad5bcb3
trie: remove unused `buf` parameter (#16583)
xincaosu 4ba3fe3
core, eth: fix tracer dirty finalization
karalabe a9d8b74
travis.yml: remove obsolete brew-cask install
reductionista d636d86
whisper: Golint fixes in whisper packages (#16637)
roveneliah 66f4b9c
vendor: fix leveldb crash when bigger than 1 TiB
992cfa5
core: ensure local transactions aren't discarded as underpriced
43a0665
evm/main: use blocknumber from genesis
holiman 268a734
accounts: golint updates for this or self warning (#16627)
kielbarry 66e23ce
tests: golint fixes for tests directory (#16640)
roveneliah c6cd831
trie: golint iterator fixes (#16639)
roveneliah 5bf6d94
internal: golint updates for this or self warning (#16634)
kielbarry 012d10b
core: golint updates for this or self warning (#16633)
kielbarry de9a332
build: Add ldflags -s -w when building aar
ligi 8bd57f6
cmd/clef: documentation about setup (#16568)
holiman 61a805b
params: release geth 1.8.7
karalabe b8c08f5
VERSION, params: begin v1.8.8 release cycle
karalabe 16f683a
log: changed if-else blocks to conform with golint (#16661)
GagziW 2751f05
p2p: changed if-else blocks to conform with golint (#16660)
GagziW 548147e
les: changed if-else blocks to conform with golint (#16658)
GagziW e878863
accounts: changed if-else blocks to conform with golint (#16654)
GagziW a52d5c8
rpc: golint error with context as last parameter (#16657)
kielbarry eccbb26
metrics: golint updates for this or self warning (#16635)
kielbarry 7aa4995
consensus/ethash: fixed typo (#16665)
YH-Zhou 559dd07
event: golint updates for this or self warning (#16631)
kielbarry 0fbb878
eth: golint updates for this or self warning (#16632)
kielbarry 69d72ba
signer: fix golint errors (#16653)
roveneliah 7183d05
whisper/mailserver: pass init error to the caller (#16671)
divan ea1b62c
common: changed if-else blocks to conform with golint (#16656)
GagziW 12bd9f5
mobile: add GetStatus Method for Receipt (#16598)
erichin 17a85bd
core/rawdb: separate raw database access to own package (#16666)
karalabe 4cf8a05
rlp: fix some golint warnings (#16659)
kielbarry 3cbf767
p2p: fix some golint warnings (#16577)
kielbarry 48e3261
eth/filters: derive FilterCriteria from ethereum.FilterQuery (#16629)
reductionista 8f6e4f3
p2p/simulations/adapters: fix websocket log line parsing in exec adap…
divan 7f0d144
build: specify the key to use when invoking gpg:sign-and-deploy-file …
ligi 2fbe9dd
crypto: fix golint warnings (#16710)
kielbarry f036627
p2p: don't discard reason set by Disconnect (#16559)
gsalgado ca3dddc
cmd: various golint fixes (#16700)
kielbarry bea6caa
eth: golint fixes to variable names (#16711)
kielbarry bc19559
eth/filter: check nil pointer when unsubscribe (#16682)
rjl493456442 dca0b9a
whisper/shhclient: update call to shh_generateSymKeyFromPassword to p…
gravityblast 2b2130b
all: get rid of error when creating memory database (#16716)
rjl493456442 7638956
event: document select case slice use and add edge case test (#16680)
fjl 88524a5
travis: use Android NDK 16b (#16562)
ligi ea40876
bmt: golint updates for this or self warning (#16628)
kielbarry cd6d63a
light: new CHT for mainnet and ropsten (#16736)
zsfelfoldi 21d929a
params: release go-ethereum v1.8.8
karalabe 70d96c4
VERSION, params: start 1.8.9 release cycle
karalabe afee1c6
accounts/abi: allow abi: tags when unpacking structs
gballet caf7944
travis: try to upgrade android builder to trusty
karalabe 80a7dd3
p2p/enr: updates for discovery v4 compatibility (#16679)
fjl 7ebea3d
all: collate new transaction events together
rjl493456442 2af7ddf
core, eth: minor txpool event cleanups
karalabe 5ea8a88
travis, appveyor: bump Go release to 1.10.2
karalabe 0e96ae8
core, consensus: fix some typos in comment code and output log
hadv 4aad778
eth: propagate blocks and transactions async
karalabe c91a062
trie: fixes to comply with golint (#16771)
kielbarry 5a313c0
log: fixes for golint warnings (#16775)
kielbarry 8fdd35f
node: all golint warnings fixed (#16773)
kielbarry 3e16ed6
vendor, ethdb: print warning log if leveldb is performing compaction …
rjl493456442 e795c92
core/types: convert status type from uint to uint64 (#16784)
rjl493456442 6f923f6
swarm: Correct ResourceParams instantiation in testutils
nolash e80a7fa
swarm/pss: Rename method to GetPeerTopics
nolash 5448749
receiver name should be a reflection of its identity; don't use gener…
ded786b
swarm/pss: Rename GetPeer to GetPublickeyEntries
nolash 7bc4c8c
pr changes
acud 4f98c5b
exported method should have comment or be unexported
84ee424
fixed logs
acud d6264f7
swarm/pss: Refactor to direct api method test
nolash 74ddda6
swarm/network: fix bzz handshake tests
nonsense 939ec38
Merge pull request #558 from ethersphere/resource-owner-validator
nolash 60cf5f7
p2p, swarm: measure number of p2p.Send calls and time them; measure n…
nonsense c560b02
fixed log messages
acud 2aa0c6d
swarm/storage: Change Lookup from name(hash) to key
nolash cdb7089
swarm/storage: Revert to name lookup, export LoadResource (takes key)
nolash 4024f7e
swarm/api, swarm/storage: Rewrite resource api for content addr key
nolash 5eb4130
swarm/storage: Add function comments
nolash d7cbeb1
swarm/api: Consolidate manifest key as entry point for mutable resource
nolash 3e64c83
swarm/api, swarm/storage: Comment update
nolash 587d4ef
swarm/api: Delint + typo
nolash 1c9fbb0
swarm/storage: Add BinaryUnmarshaler to resource
nolash cd0dd2e
swarm/storage: Update validator to correct metadata chunk check
nolash 6ece30c
swarm/storage: Rename indexSize, edit comments
nolash afcb96f
Merge pull request #590 from ethersphere/measurements_len_peers_p2p_send
nonsense 5685cc2
Merge pull request #538 from ethersphere/bzz_networkid_fix
nonsense 3f166c4
swarm/network/simulations: Skip TestOverlaySim
gbalint b262996
p2p, swarm: use different names for counter and timer
nonsense 52ad151
Merge pull request #597 from ethersphere/fix_counter_timer_naming
nonsense 2aec12e
Merge pull request #596 from ethersphere/disable-test-overlay-sim
nonsense 6f2d560
swarm-network-rewrite conflicts with master (#589)
nonsense 80a29d2
resolved conflicts with master
nonsense 3565149
Merge pull request #599 from ethersphere/conflicts_with_snr
nonsense 370e67f
loglevel
acud 3d7e57b
Merge pull request #541 from ethersphere/resource-rootchunk-refactor
zelig 3520723
Merge branch 'swarm-network-rewrite' into swarm-network-rewrite-golin…
8f584c8
implement recommendation from @nonsense
9386c44
Merge pull request #587 from dleonard00/swarm-network-rewrite-golint-…
nonsense 5ad2d33
Merge pull request #575 from ethersphere/pss-havepeer
nolash 90b7fb7
Merge pull request #543 from ethersphere/cli-add-fuse
zelig 1a44f0a
bmt, pot: move into swarm package (#603)
acud f9811d2
swarm/network/stream/delivery: byte comparison on error nil (#622)
acud e3a63d1
swarm/fuse: do not support relative path for fuse mounting (#629)
acud e46cce1
swarm: do not set nil resolver for interface types
janos 7ceb685
p2p/simulations: Log if watchPeerEvents can't find node
gbalint 67c3491
Merge pull request #636 from ethersphere/fix-p2psim-panic
zelig 9d0a463
Rename storage.Key to storage.Address (#643)
gbalint 2e63d02
swarm: grafana dashboards under vc
nonsense 9b90911
swarm/storage: Separate mutable resources into separate package
nolash 02f5d35
swarm/storage: Rename resource to mru
nolash 1640eff
swarm/storage: godoc
nolash e10d359
swarm: Rebase of mru package separate onto resource rootchunk refactor
nolash e450099
swarm: Remove "Resource" from mru method and type names
nolash 9c330a6
Revert "Rename storage.Key to storage.Address (#643)" (#650)
gbalint 08e35e9
Merge pull request #561 from ethersphere/resource-separate
nolash ef4ea15
swarm/storage: Rename storage.Key to storage.Address (#643)
nolash 7736a44
Merge pull request #651 from ethersphere/swarm-network-rewrite-addrnew
nolash 63a334f
Merge pull request #635 from ethersphere/fix-resolver-panic
zelig 374e767
Merge pull request #646 from ethersphere/grafana_dashboards
nonsense c35aa32
make topic readable in error messages (#540)
vmaark a4487d8
merge master to swarm-network-rewrite (#655)
nonsense c09a246
swarm/pss: Rename "self" receivers to reflect better their identity
skylenet af043f7
Rename DPA to FileStore (#660)
gbalint f2fd16c
Merge pull request #662 from skylenet/pss-self-receivers-refactor
nonsense 20870eb
swarm/api: fix linter error
nonsense 8f706b2
Merge pull request #664 from ethersphere/fix_linter_err
zelig 3e49fde
swarm, swarm/storage: pyramid spilt fix (#661)
janos bff4657
swarm/pss: Pssmsg flags (#637)
nolash 6ffbfb2
swarm: added copyright headers (#669)
acud 4870d43
swarm/network: scale down test - TestFileRetrieval
nonsense 1093d59
swarm/network: fewer data chunks for tests
nonsense ca733ef
swarm/storage: fewer tests for chunker
nonsense 131524b
swarm/network: change snapshot to 16 nodes, as there is no snapshot f…
nonsense be2512c
swarm: TestLocalStoreAndRetrieve optimization with longrunning flag
janos 66b8612
Merge pull request #674 from ethersphere/scale_down_test
nonsense 99ef857
Merge pull request #676 from ethersphere/testlocalstoreandretrieve-lo…
nonsense 6e758ed
swarm/storage: debug for closed channel
nonsense 89eee16
Merge pull request #683 from ethersphere/debug_line_closing_channel
nonsense 620a31c
p2p, swarm: do not log shutting down as error (#679)
nonsense e5ae94a
swarm/network: disable TestSuggestPeerRetries (#677)
nonsense 40b6017
swarm/pss: add error logging ; amend timeouts (#653)
nonsense 148fe04
swarm/store: ldbstore quit channel to terminate running loops
janos 6cedb53
swarm/storage: ulock LDBStore.lock on quit chan break in writeBatches
janos 6386433
swarm: wrap logger with stats for Warn, Crit and Error
nonsense f10cb2c
swarm/log: log more useful logline
nonsense 6a659c3
swarm: revert wrapping of logger in tests
nonsense d934367
swarm/storage: remove spammy log line (#687)
nonsense 86cd38f
swarm/network: Log unexpected db error
gbalint 09ef09e
swarm/network: Add logging to see if chunks to delivered are too shor…
gbalint 0d065f4
swarm/storage: Let's not panic on db error, just log it
gbalint b81b444
Merge pull request #689 from ethersphere/log-db-error
nonsense 1c945bf
Merge pull request #680 from ethersphere/wrap_logger_with_stats
nonsense f3ea311
swarm/api/http: implement bufferedReadSeeker and use it in HandleGetF…
janos 27c33bb
p2p/protocols: do not log EOF error
nonsense eb1550b
Merge pull request #693 from ethersphere/ignore_eof_log
nonsense 65623b1
swarm/storage: close channel only after we have replaced chunk in mem…
nonsense 2e102cb
swarm/storage: get rid of go-routine that waits on <-dbStoredC
nonsense a96f347
swarm/pss: Increment pss message version
nolash 9d46f81
Merge pull request #686 from ethersphere/ldbstore-quit
zelig 2d9dbed
Merge pull request #695 from ethersphere/fix-panic-closed-channel
zelig 3acc595
swarm/hash: Custom multihash implementation (#633)
nolash 221e5b4
Swarm network rewrite golint warnings (#656)
dleonard00 d472be2
Merge pull request #698 from ethersphere/pss-version-bump
nonsense 3579fb2
swarm/fuse: disable fuse tests (#692)
nonsense 613436f
swarm/storage: do not close rh.chunkstore
nonsense f8a65c1
Merge pull request #700 from ethersphere/do_not_close_rh_chunkstore
nonsense a26b174
swarm/bmt: major braking change in hash
zelig 18992f3
swarm/storage: rename bmt constants referenced
zelig e4a9351
swarm/api/http: change expected hashes
zelig 3906663
swarm/bmt: fixes, optimisations, comments
zelig 9aa6056
swarm/storage: branches argument is not used, so remove it
nonsense 25afc17
swarm/storage: remove NewTreeSplitterParams as it is just indirection
nonsense 12884f1
swarm/storage: less aritmetics and more explicit initialisation
nonsense 3b10ece
swarm/bmt: address review comments
zelig 9da4f8e
Merge pull request #701 from ethersphere/remove_redundant_argument
nonsense f239d0d
swarm: cleanup created resources for fuse
holisticode 5e84607
swarm: refactoring fuse tests
holisticode 80f3cb6
swarm: refactored fuse tests
holisticode b8580a6
swarm: Sleep after fs.Serve in fuse;avoids deadlocks
holisticode 1f27b44
Merge pull request #691 from ethersphere/bmt
zelig 26762ed
swarm/api/config.go:62:2: struct field NetworkId should be NetworkID
dleonard00 eb3dd15
swarm/api/config.go:67:2: struct field SwapApi should be SwapAPI
dleonard00 32bce11
swarm/api/config.go:103:1: receiver name should be a reflection of it…
dleonard00 bd3e660
swarm/api/filesystem.go:50:1: receiver name should be a reflection of…
dleonard00 b240650
swarm/api/manifest.go:263:1: receiver name should be a reflection of …
dleonard00 618aa99
swarm/api/manifest.go:149:5: error var SkipManifest should have name …
dleonard00 3c75cae
swarm/api/storage.go:48:1: receiver name should be a reflection of it…
dleonard00 3eafe78
swarm/api/testapi.go:44:1: receiver name should be a reflection of it…
dleonard00 4067701
swarm/api/http/server.go:88:1: comment on exported function StartHttp…
dleonard00 cafd0f8
swarm/api/http/error.go:197:9: if block ends with a return statement,…
dleonard00 6eb7f9e
swarm/api/http/error.go:178:6: func respondHtml should be respondHTML
dleonard00 fd427f7
swarm/pss/pss.go:932:10: if block ends with a return statement, so dr…
dleonard00 24865f7
swarm/pss/handshake.go:429:9: if block ends with a return statement, …
dleonard00 701ef47
swarm/pss/handshake.go:63:2: struct field symKeyId should be symKeyID
dleonard00 4197023
swarm/storage/types.go:128:1: receiver name addr should be consistent…
dleonard00 2baad9d
swarm/storage/swarmhasher.go:38:1: receiver name should be a reflecti…
dleonard00 d7d3d95
swarm/storage/pyramid.go:238:1: receiver name should be a reflection …
dleonard00 3db2e74
swarm/storage/netstore.go:179:1: receiver name should be a reflection…
dleonard00 214c36d
swarm/storage/localstore.go:158:1: receiver name should be a reflecti…
dleonard00 4d30d3b
swarm/storage/hasherstore.go:150:1: receiver name p should be consist…
dleonard00 40bb0be
swarm/storage/filestore.go:90:1: receiver name should be a reflection…
dleonard00 8d0b6fe
swarm/storage/dbapi.go:50:1: receiver name should be a reflection of …
dleonard00 85dadfb
swarm/storage/database.go:72:1: receiver name should be a reflection …
dleonard00 14183e9
swarm/storage/chunker.go:534:1: receiver name should be a reflection …
dleonard00 e949a22
swarm/storage/mru/resource.go:935:1: receiver name should be a reflec…
dleonard00 22ce5d0
swarm/network: bump up bzz protocol version to 4, because of BMT hashes
nonsense 030bdeb
swarm/network: increase protocol version for `stream` and `hive`
nonsense ab4a8d0
swarm: removed flag for mac fuse unmount
holisticode ec10755
Fix storage benchmark tests (#708)
gbalint 7977387
Merge pull request #706 from MainframeHQ/swarm-network-rewrite-golint2
nonsense 39ddeeb
Merge pull request #707 from ethersphere/bump_up_bzz_proto_version
nonsense 735749c
swarm/pss: move EnableMetrics away from testutil
nonsense babe5a2
Merge pull request #652 from holisticode/fuse-stall
holisticode 169b2b1
swarm/storage: detect potential panics on short chunk data (#711)
janos bda34fe
swarm/api/http: set ETag header with correct syntax
janos e554dd6
Merge pull request #714 from ethersphere/etag-fix
zelig ba22f7f
Merge pull request #712 from ethersphere/move_enablemetrics_to_pss
nonsense 12735ca
resolved conflicts
nonsense fec74a7
swarm/pss: replace ToECDSAPub with error-checking func UnmarshalPubkey
nonsense b01b363
swarm/storage: downgrade 'invalid content address' error to trace log…
janos d151d9e
Merge pull request #716 from ethersphere/master_to_snrw
nonsense 3ad9d21
vendor: remove unused libraries
nonsense a71046c
Merge pull request #717 from ethersphere/sync_snr_with_master
nonsense 9d35ceb
swarm, swarm/storage: handle compress edge cases in pyramid chunker (…
janos bb26ae1
swarm/api: update log.Output to report meaningful log line
nonsense be1516f
swarm/storage: fix lint warning in Validate function (#721)
janos f4d0128
Merge pull request #720 from ethersphere/correct_calldepth_for_output
zelig 11c5cbd
swarm/pss: Update benchmark tests
nolash 2ba153e
just change the background color as per the suggestion by @homotopyco…
dleonard00 86c5515
Merge pull request #724 from MainframeHQ/redesign-error-page
zelig d1de7b7
swarm/api/http: add tests for buffered http get for both bzz and bzz-raw
janos ee666bf
swarm/api/http: raise the tolerance for buffered get tests results
janos 3c3731f
Merge branch 'master' into swarm-network-rewrite
gbalint 1039a4b
Merge pull request #725 from ethersphere/bufferedget-test
zelig 303966c
Merge pull request #723 from ethersphere/pss-benchmark-frenzy
zelig 66ff122
Merge branch 'master' into swarm-network-rewrite
gbalint File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't that be better with a flag then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDEs are hard to configure to use custom flags for every test, I personally find it easier to uncomment the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this, but I have had comments on my PRs to have such comments removed. Maybe we should discuss it in a roundtable?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@holisticode sure, let's discuss this. I agree in general that we should not keep dead code, especially in the production code, however I already removed this once from tests, and then we had to introduce it yet again with @nolash . I also think this specific line will be helpful for other tests in the future.
I have definitely been against dead code in the production code in the past, and if you feel strongly that this is the same, I will be happy to remove it! :)
On a second thought adding it as a flag is also a possibility, I could just have a custom keybinding triggering with the flag :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong feelings, just aiming at consistent handling.