This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swarm/storage: remove traces for put/get/set#1389
Merged
acud merged 2 commits intoswarm-rather-stablefrom May 9, 2019
Merged
Conversation
acud
approved these changes
May 9, 2019
nonsense
added a commit
that referenced
this pull request
May 10, 2019
* swarm/storage: remove traces for put/get/set * swarm/storage: remove Has traces
nonsense
added a commit
that referenced
this pull request
May 10, 2019
swarm/storage: remove traces for put/get/set (#1389) * swarm/storage: remove traces for put/get/set * swarm/storage: remove Has traces
nonsense
added a commit
that referenced
this pull request
May 10, 2019
swarm/storage: remove traces for put/get/set (#1389) * swarm/storage: remove traces for put/get/set * swarm/storage: remove Has traces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As anticipated and mentioned in the PR when we merged this, these traces are not really useful and are quite spammy.
I think for now it is enough to have instrumentation only in terms of counters and timers in the LocalStore, I don't really see the need for individual traces for every single Get/Set/Put.
We already have a lot of spans in a trace (see screenshot), we should try to limit them.