This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swarm/network: remove redundant goroutine#1377
Merged
nonsense merged 1 commit intoswarm-rather-stablefrom May 8, 2019
Merged
Conversation
nonsense
force-pushed
the
remove-redundant-goroutine
branch
from
f9e7cfd to
87db7c8
Compare
zelig
approved these changes
May 7, 2019
nonsense
added a commit
that referenced
this pull request
May 10, 2019
nonsense
added a commit
that referenced
this pull request
May 10, 2019
nonsense
added a commit
that referenced
this pull request
May 10, 2019
nonsense
added a commit
that referenced
this pull request
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing OpenTracing trace for
handle.offered.messages- syncing protocol traces are not useful currently as we still have a priority queue here, so we just spam Jaeger, making it difficult to trace RetrieveRequests.Removing the last go routine, because
handleOfferedMessagesitself is called in a goroutine so it is no longer needed.