This repository was archived by the owner on Aug 2, 2021. It is now read-only.
cmd/swarm-smoke: check if chunks are at most prox host#1353
Merged
nonsense merged 1 commit intoswarm-rather-stablefrom Apr 26, 2019
Merged
cmd/swarm-smoke: check if chunks are at most prox host#1353nonsense merged 1 commit intoswarm-rather-stablefrom
nonsense merged 1 commit intoswarm-rather-stablefrom
Conversation
nonsense
commented
Apr 26, 2019
| return | ||
| } | ||
|
|
||
| bzzAddr := strings.Split(strings.Split(hive, "\n")[3], " ")[10] |
Contributor
Author
There was a problem hiding this comment.
This is rather ugly - do we have an API that returns the bzz addr for a given host? admin.NodeInfo doesn't have that information, it has only id and enode.
nonsense
commented
Apr 26, 2019
| } | ||
|
|
||
| // getChunksBitVectorFromHost returns a bit vector of presence for a given slice of chunks from a given host | ||
| func getChunksBitVectorFromHost(client *rpc.Client, addrs []storage.Address) (string, error) { |
Contributor
Author
There was a problem hiding this comment.
getChunksBitVectorFromHost and getBzzAddrFromHost really don't belong here - there should be a package which provides a type-safe bzz client from an rpcClient, which has all APIs exposed in bzz configured in it, but since we don't have one, I am defining them here.
We might want to add this once we start using these APIs a bit more often, but for now, I think its fine for this to live here.
nonsense
force-pushed
the
smoke-tests-sync-check
branch
from
5f32691 to
ebfa52f
Compare
janos
approved these changes
Apr 26, 2019
Member
janos
left a comment
janos
left a comment
There was a problem hiding this comment.
The functionality seems correct.
nonsense
added a commit
that referenced
this pull request
May 10, 2019
nonsense
added a commit
that referenced
this pull request
May 10, 2019
swarm/network: measure how many chunks a node delivers (#1358)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adding two checks performed on the
upload_and_syncsmoke test:Together with the
--only-uploadflag, we could run this smoke test and make sure that our syncing functionality is correct (without even trying to retrieve the content). If we see errors, it means that we should focus on syncing, before we try to investigate further timeouts on retrieve request side and on fetchers.@holisticode I know we have a unit test for this, but I am getting errors when running this in a deployment. So we need to understand better why they happen.