This repository was archived by the owner on Aug 2, 2021. It is now read-only.
p2p/protocols, swarm/network: fix p2p resource leak#1346
Merged
acud merged 1 commit intoswarm-rather-stablefrom Apr 26, 2019
Merged
p2p/protocols, swarm/network: fix p2p resource leak#1346acud merged 1 commit intoswarm-rather-stablefrom
acud merged 1 commit intoswarm-rather-stablefrom
Conversation
gluk256
approved these changes
Apr 25, 2019
nonsense
pushed a commit
that referenced
this pull request
May 10, 2019
nonsense
pushed a commit
that referenced
this pull request
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes the resource leak due to improper shutdown of p2p server on
p2p/protocoltester.we are still leaking keystores but this is a bit more hard to pin down, since the keystore directory is created side-by-side with the node data directory. I think this is done when the geth components get bootstrapped and the keystore gets created automatically.
fixes #1322