This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swarm/chunk, swarm/storage: adjust Store.Put interface to return boolean on chunk exists#1330
Merged
acud merged 3 commits intolocalstore-storage-integrationfrom Apr 9, 2019
Merged
Conversation
janos
reviewed
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a boolean return value to the
Store.Putinterface method in order to indicate whether a chunk already exists in the database when doing aPut. This is in order to allow for a correct chunk count when chunking a file.This will serve as a measure to correctly count added chunks correctly so we could calculate how many chunks a push sync tag has on the fly.
Using this approach we avoid adding the tag vector field in
shed.Itemandchunk.chunk.I have adjusted the test that puts duplicate chunks into the database to cover this test. If further tests are needed please do tell.
part of #1019