This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swarm/network/stream: file retrieval test race#1215
Closed
acud wants to merge 1 commit into
Closed
Conversation
acud
force-pushed
the
file-retrieval-race
branch
2 times, most recently
from
0b177cb to
14a4ff1
Compare
acud
force-pushed
the
file-retrieval-race
branch
2 times, most recently
from
15630be to
f5d73ae
Compare
swarm/network/stream: remove netstore internal wg swarm/network/stream: run individual tests with t.Run
acud
force-pushed
the
file-retrieval-race
branch
from
f5d73ae to
0187057
Compare
Contributor
Author
|
submitted upstream ethereum/go-ethereum#19049 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR addresses a possible race when shutting down the netstore while fetchers are still running.
the PR iterates over the fetchers and cancels them, then waits for the cancellation to propagate on netstore shutdown
fixes #1197