Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

swarm: fix uptime gauge update goroutine leak#1212

Closed
acud wants to merge 1 commit intomasterfrom
fix-uptime-ticker-leak
Closed

swarm: fix uptime gauge update goroutine leak#1212
acud wants to merge 1 commit intomasterfrom
fix-uptime-ticker-leak

Conversation

@acud
Copy link
Copy Markdown
Contributor

@acud acud commented Feb 11, 2019

fixes #1156 by introducing cleanup functions to allow for custom shutdown callbacks

@acud acud requested a review from janos February 11, 2019 07:02
Copy link
Copy Markdown
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Elad.

@acud
Copy link
Copy Markdown
Contributor Author

acud commented Feb 12, 2019

reopened on upstream ethereum/go-ethereum#19040

@acud acud closed this Feb 12, 2019
@acud acud deleted the fix-uptime-ticker-leak branch April 11, 2019 03:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible goroutine leak in Swarm.Start

2 participants