This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Conversation
nonsense
approved these changes
Jan 29, 2019
janos
approved these changes
Jan 29, 2019
Contributor
Author
|
submitted upstream ethereum/go-ethereum#18964 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1161 ... The bug was that by passing
n=1to the second protocol tester, an additional node was created.While adding comments to the tests in this file in an attempt to explain what they do, I also uncovered a synchonicity discrepancy in the
TestRegisterAndConnecttest. This theoretically makes it pass before connection has been made. I added the fix to this PR.It would perhaps be more correct to add a
TestConnectedmethod toProtocolSession(along the lines ofTestDisconnected) instead of the connect test loop inTestRegisterAndConnectthat I've added here. However, if this is the only place we care about whether connection is actually up maybe it could just stay like this for now.