You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 2, 2021. It is now read-only.
The reason will be displayed to describe this comment to others. Learn more.
For my part this is now ok. But I am not at all sure whether the idea I have of "healthiness" is the right one anymore. So I defer judgement. My advice is to have two more approvals of this besides mine from someone who understands the terms that are in use.
I had a discussion with @holisticode about this. IMHO healthy is primarily used as a stop condition in simulation tests
Since the current version only checks nearest neighbours, saturation of bins shallower than depth is not checked.
With another implementation of hive discovery, unhealthy kademlias could pass as healthy.
But saturation check cannot be absolute since we can have situations that there is simply less than MinBinSize peers for a node in a bin. Therefore the peer pot has to be enriched with the counts of potential peers for each bin (upto depth at least) for each node.
These cardinalities can be passed to the health function via a slice of integers which are compared to known and connected peers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the parameter
Robustto theHealthystructure.Robustdenoteswhether we are connected to a minimum of peers in all the bins we have known peers in.It is meant as a discussion PR until we reach consensus on how this parameter will be used.
For reviewers other than @nolash :
You are welcome to leave comments but this is not yet ready for formal review.