This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Closed
Conversation
3ffb5cd to
fdb2e12
Compare
gluk256
approved these changes
Jan 22, 2019
701540b to
5a27399
Compare
nonsense
reviewed
Jan 22, 2019
nonsense
reviewed
Jan 22, 2019
nonsense
reviewed
Jan 22, 2019
nonsense
suggested changes
Jan 23, 2019
Contributor
nonsense
left a comment
There was a problem hiding this comment.
While I like the simplification of the wrap function, I am not sure this is the test when downloading all historical hashes that were uploaded.
29cd89a to
b7ec0a6
Compare
janos
reviewed
Jan 25, 2019
Member
janos
left a comment
There was a problem hiding this comment.
This is not a complete review. I still did not go through all changes.
nonsense
reviewed
Jan 25, 2019
nonsense
reviewed
Jan 25, 2019
janos
reviewed
Jan 25, 2019
Member
janos
left a comment
There was a problem hiding this comment.
Additional comments to the first review.
ba58240 to
3641a4e
Compare
janos
approved these changes
Jan 28, 2019
Member
janos
left a comment
There was a problem hiding this comment.
@justelad Thank you for addressing my comments and suggestions. LGTM.
654afc8 to
a3b4558
Compare
janos
reviewed
Jan 29, 2019
a3b4558 to
24f818e
Compare
24f818e to
2140921
Compare
Contributor
Author
|
submitted upstream ethereum/go-ethereum#18967 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1095
example kubernetes deployment manifest: