Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

Fix T.Fatal inside a goroutine in tests#1090

Closed
janos wants to merge 5 commits intomasterfrom
fix-netstore-SA2002
Closed

Fix T.Fatal inside a goroutine in tests#1090
janos wants to merge 5 commits intomasterfrom
fix-netstore-SA2002

Conversation

@janos
Copy link
Copy Markdown
Member

@janos janos commented Jan 7, 2019

This PR addresses test issues in #1055 for:

  • swarm simulation
  • stream
  • netstore
swarm/network/simulation/events_test.go:84:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/network/simulation/http_test.go:76:2: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
swarm/network/simulation/http_test.go:76:2: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
swarm/network/stream/delivery_test.go:556:3: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
swarm/network/stream/delivery_test.go:573:3: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/network/stream/delivery_test.go:705:3: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/network/stream/intervals_test.go:166:3: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/network/stream/snapshot_sync_test.go:218:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/network/stream/snapshot_sync_test.go:401:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/network/stream/syncer_test.go:147:3: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:117:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:117:2: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:203:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:246:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:289:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:289:2: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:306:3: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:306:3: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:549:3: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
swarm/storage/netstore_test.go:613:3: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)

@janos janos changed the title Fix T.Fatal inside a goroutine in NetStore tests Fix T.Fatal inside a goroutine in tests Jan 7, 2019
Copy link
Copy Markdown
Contributor

@frncmx frncmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor things I commented on
LGTM

Comment thread swarm/network/simulation/events_test.go Outdated
Comment thread swarm/network/simulation/http_test.go Outdated
Comment thread swarm/storage/netstore_test.go
Copy link
Copy Markdown
Contributor

@frncmx frncmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @janos! Ship it.

@janos
Copy link
Copy Markdown
Member Author

janos commented Jan 8, 2019

Thank you all for review. It is submitted upstream ethereum/go-ethereum#18409.

@zelig
Copy link
Copy Markdown
Member

zelig commented Jan 10, 2019

merged as ethereum/go-ethereum#18409

@zelig zelig closed this Jan 10, 2019
@frncmx frncmx deleted the fix-netstore-SA2002 branch January 22, 2019 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants