This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swarm/network: Refactor peer suggestion engine#1073
Closed
Conversation
nolash
requested review from
acud,
holisticode,
janos,
lmars,
nonsense and
zelig
as code owners
nolash
force-pushed
the
is-there-anybody-out-there
branch
from
26a1521 to
7835637
Compare
nolash
force-pushed
the
is-there-anybody-out-there
branch
from
8a0d503 to
2f83537
Compare
zelig
reviewed
Jan 3, 2019
Member
zelig
left a comment
zelig
left a comment
There was a problem hiding this comment.
just took a look. Risky PR
changes a LOT of code around without adding a fix or algorithmic improvement
| } | ||
|
|
||
| // | ||
| lastPotentialBin++ |
| }) | ||
| if ins && !p.BzzPeer.LightNode { | ||
| a := newEntry(p.BzzAddr) | ||
| a.conn = p |
|
|
||
| // knowNearestNeighbours tests if all known nearest neighbours given as arguments | ||
| // are found in the addressbook | ||
| // knowNeighbours tests if all neighbours in the peerpot |
Member
There was a problem hiding this comment.
should this not be knownNeighbours similar to connectedNeighbours?
| return connects == len(peers), connects, culprits | ||
| } | ||
|
|
||
| // connectedPotential checks whether the peer is connected to a health minimum of peers it knows about in bins that are shallower than depth |
Contributor
Author
|
On hold pending success of (along the lines of) ethereum/go-ethereum#18404 |
Contributor
Author
|
Discontinued due to ethereum/go-ethereum#18404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify and cleanly encapsulate the component that informs which peers to attempt connections to, and which peers to request.
The implicit aim is to attain a clear and logical separation of responsbility and functionality between the files
hive.go,kademlia.goanddiscovery.go.merge dependencies (in order of merge to master):
swarm/network: Make MinProxBinSize constant across simulation #1074