Skip to content
This repository was archived by the owner on Jun 26, 2019. It is now read-only.

Document bzz-list, bzz-raw and bzz-immutable schemes#44

Merged
janos merged 4 commits into
masterfrom
bzz-list-scheme
Dec 20, 2017
Merged

Document bzz-list, bzz-raw and bzz-immutable schemes#44
janos merged 4 commits into
masterfrom
bzz-list-scheme

Conversation

@janos
Copy link
Copy Markdown
Member

@janos janos commented Dec 19, 2017

PR ethereum/go-ethereum#15667 has been merged to ethereum master and this change updates the documentation.

@janos janos requested review from gbalint and lmars December 19, 2017 09:32
Comment thread contents/usage.rst Outdated

GET http://localhost:8500/bzz-list:/2477cc8584cc61091b5cc084cdcdb45bf3c6210c263b0143f030cf7d750e894d

Returns a list of all files contained in <manifest> under <path> grouped into common prefixes using ``/`` as a delimiter. The response is a JSON-encoded object with ``common_prefixes`` string field and ``entries`` list field.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment refers to <manifest> and <path> but they don't appear in the example?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the description is not so clear with this example. Updated.

Comment thread contents/usage.rst Outdated

bzzr and bzzi
^^^^^^^^^^^^^^
Schemes with short names bzzr and bzzi are deprecated in favour of bzz-raw and bzz-immutable, respectably. They are kept for backward compatibility, and will be removed on the next release.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/respectably/respectively

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( Thank you.

Comment thread contents/simpleuser.rst Outdated
-------------

Setting `list=true` in the query of a `GET` request returns a list of files contained under the path, grouped into common prefixes which represent directories:
A `GET` request with bzz-list url scheme returns a list of files contained under the path, grouped into common prefixes which represent directories:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe bzz-list can be teletyped or bold for readability

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and updated 👍

Comment thread contents/usage.rst
GET http://localhost:8500/bzz-immutable:/2477cc8584cc61091b5cc084cdcdb45bf3c6210c263b0143f030cf7d750e894d

The same as the generic scheme but there is no ENS domain resolution, the domain part of the path needs to be a valid hash. This is also a read-only scheme but explicit in its integrity protection. A particular bzzi url will always necessarily address the exact same fixed immutable content.
The same as the generic scheme but there is no ENS domain resolution, the domain part of the path needs to be a valid hash. This is also a read-only scheme but explicit in its integrity protection. A particular bzz-immutable url will always necessarily address the exact same fixed immutable content.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"also read-only but explicit in its integrity protection" -> this is a strange formulation.

@janos janos merged commit 9c13617 into master Dec 20, 2017
@janos janos deleted the bzz-list-scheme branch December 20, 2017 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants