-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump go version to 1.21.0 #4250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notanatol
force-pushed
the
bump-go-1.21
branch
from
August 18, 2023 06:36
f994f50
to
878ce00
Compare
notanatol
force-pushed
the
bump-go-1.21
branch
from
August 19, 2023 07:31
878ce00
to
cc6f3d3
Compare
notanatol
force-pushed
the
bump-go-1.21
branch
from
August 20, 2023 06:29
98fc4d1
to
ae1fc27
Compare
notanatol
added
ready for review
The PR is ready to be reviewed
and removed
on hold
Temporarily halted by other development
labels
Aug 20, 2023
istae
approved these changes
Aug 21, 2023
mrekucci
reviewed
Aug 21, 2023
@@ -10,11 +10,12 @@ import ( | |||
"fmt" | |||
"testing" | |||
|
|||
"slices" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in the upper group. The same below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the gofumpt
formatter and they got re-arranged now
notanatol
force-pushed
the
bump-go-1.21
branch
from
August 21, 2023 11:35
ae1fc27
to
3cba435
Compare
notanatol
force-pushed
the
chore-upgrade-libp2p-v26
branch
from
August 21, 2023 11:54
d3b8b9b
to
a6e2dbb
Compare
notanatol
force-pushed
the
bump-go-1.21
branch
from
August 21, 2023 12:01
3cba435
to
09b94f5
Compare
mrekucci
approved these changes
Aug 22, 2023
notanatol
force-pushed
the
chore-upgrade-libp2p-v26
branch
2 times, most recently
from
September 8, 2023 06:19
1f6e7a4
to
17d07dc
Compare
notanatol
force-pushed
the
bump-go-1.21
branch
from
September 8, 2023 06:59
09b94f5
to
3156bfa
Compare
mrekucci
pushed a commit
that referenced
this pull request
Oct 16, 2023
mrekucci
pushed a commit
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Go 1.21.0 is out so starting a PR to keep bee up to date.
Linked to #3927