Fix WebSocket Provider Block Subscription#849
Closed
cavanmflynn wants to merge 1 commit intoethers-io:ethers-v5-betafrom
cavanmflynn:cf-fix-new-heads-subscription
Closed
Fix WebSocket Provider Block Subscription#849cavanmflynn wants to merge 1 commit intoethers-io:ethers-v5-betafrom cavanmflynn:cf-fix-new-heads-subscription
cavanmflynn wants to merge 1 commit intoethers-io:ethers-v5-betafrom
cavanmflynn:cf-fix-new-heads-subscription
Conversation
Member
|
Awesome! Thanks. I'll merge and test tomorrow. :) |
ricmoo
added
enhancement
Member
|
A typo in the commit message missed linking this. Please see 180a1af. This should be fixed now in 5.0.0-beta.189, please try it out and let me know if you still have any problems. |
Author
|
Thanks for the quick response! LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the second argument, an empty object, from the block header subscription call in the WebSocket provider.
Both Geth and Parity throw due to the presence of a second argument. There was a time when Geth expected an empty object to be passed, but this has since been removed to keep compatibility with Parity.
Geth Error:
Error: too many arguments, want at most 1Parity Error:
Couldn't parse parameters: newHeads