Problem with typings

[TrejGun]

Ethers Version

6.3.0

Search Terms

No response

Describe the Problem

Hey there, it's time for me to migrate from v5 to v6 and I have some problems, can you please help me to solve them?!

1 log types are incompatible

import { Interface, JsonRpcProvider, Log, LogDescription } from "ethers";

const provider = new JsonRpcProvider();
const logs: Log[] = await provider.send("eth_getLogs", [
      {
        address,
        fromBlock,
        toBlock,
        topics,
      },
    ]);

const iface = new Interface(ERC721abi);

 for (const log of logs) {
      const description = iface.parseLog(log); // <-- ERROR
}

TS2345: Argument of type 'Log' is not assignable to parameter of type '{ topics: string[]; data: string; }'.   
Types of property 'topics' are incompatible.     
The type 'readonly string[]' is 'readonly' and cannot be assigned to the mutable type 'string[]'.

I guess the reason is

parseLog(log: { topics: Array<string>, data: string}): null | LogDescription {

that has to be

parseLog(log: Log): null | LogDescription {

[nlordell]

I think you can just change the parseLog signature to:

parseLog(log: { topics: ReadonlyArray<string>, data: string }): null | LogDescription {
    // ...
}

One way to work around this is to augment the ethers modules typings with something like this:

// ethers.d.ts
import type { LogDescription } from 'ethers'

declare module 'ethers' {
  interface Interface {
    parseLog(log: { topics: ReadonlyArray<string>; data: string }): null | LogDescription
  }
}

[ricmoo]

Fixed in v6.11.0.

Thanks! And let me know if you still have any issues. :)