Skip to content

Commit

Permalink
Re-enable AlchemyProvider Berlin tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
ricmoo committed Apr 2, 2021
1 parent ef5a2b4 commit bec066b
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions packages/tests/src.ts/test-providers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -682,9 +682,6 @@ Object.keys(blockchainData).forEach((network) => {
tests.transactions.forEach((test) => {
addObjectTest(`fetches transaction ${ test.hash }`, async (provider: ethers.providers.Provider) => {
const tx = await provider.getTransaction(test.hash);
//console.log("TX");
//console.dir(test, { depth: null })
//console.dir(tx, { depth: null })

// This changes with every block
assert.equal(typeof(tx.confirmations), "number", "confirmations is a number");
Expand All @@ -695,12 +692,13 @@ Object.keys(blockchainData).forEach((network) => {

return tx;
}, test, (provider: string, network: string, test: TestDescription) => {
if (network === "ropsten" && (provider === "AlchemyProvider" || provider === "PocketProvider")) {
// Temporary
if (network === "ropsten" && provider === "PocketProvider") {
console.log(`Skipping ${ provider }; incomplete Berlin support`);
return true;
}

return false; //(provider === "EtherscanProvider");
return false;
});
});

Expand Down Expand Up @@ -810,7 +808,8 @@ testFunctions.push({
timeout: 300, // 5 minutes
networks: [ "ropsten" ], // Only test on Ropsten
checkSkip: (provider: string, network: string, test: TestDescription) => {
return (provider === "PocketProvider" || provider === "EtherscanProvider" || provider === "AlchemyProvider");
// Temporary
return (provider === "PocketProvider" || provider === "EtherscanProvider");
},
execute: async (provider: ethers.providers.Provider) => {
const wallet = fundWallet.connect(provider);
Expand Down

0 comments on commit bec066b

Please sign in to comment.