Prevent non-typed transactions from unsafely ignoring specified acces…

…s lists (#1364).
ethers-io · Apr 18, 2021 · 4577444 · 4577444
1 parent 1cb3199
commit 4577444
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/transactions/src.ts/index.ts b/packages/transactions/src.ts/index.ts
@@ -252,7 +252,12 @@ function _serialize(transaction: UnsignedTransaction, signature?: SignatureLike)
 
 export function serialize(transaction: UnsignedTransaction, signature?: SignatureLike): string {
     // Legacy and EIP-155 Transactions
-    if (transaction.type == null) { return _serialize(transaction, signature); }
+    if (transaction.type == null) {
+        if (transaction.accessList != null) {
+            logger.throwArgumentError("untyped transactions do not support accessList; include type: 1", "transaction", transaction);
+        }
+        return _serialize(transaction, signature);
+    }
 
     // Typed Transactions (EIP-2718)
     switch (transaction.type) {