Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mv opcodes, opFns and logTable to lib/vm #425

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Mv opcodes, opFns and logTable to lib/vm #425

merged 2 commits into from
Jan 29, 2019

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jan 23, 2019

This is a part of a larger refactoring effort to modularize evm code and prepare for later integration of ewasm.

The other PR didn't properly detect these file renames and produced a huge diff. This PR only moves logTable.js, opcodes.js and opFns which are internal to evm to lib/vm.

@coveralls
Copy link

coveralls commented Jan 23, 2019

Coverage Status

Coverage remained the same at 91.018% when pulling b35f49a on refactor/vm-1 into 8d6ec92 on master.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all this is internal, did also do code searches for file references which might have been forgotten.

This should nevertheless be mentioned in release notes encompassing the changes in case someone has monkey-patched around this. 🐒 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants