e2store: examples directory and README update#4042
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
a7542fa to
1f9482f
Compare
| console.log(body) | ||
| console.log(receipts) | ||
| } | ||
| // ./examples/e2hs.ts#L29-L32 |
There was a problem hiding this comment.
Ah, we had this discussion on some of Amir's PRs already, so this by-line-inclusion tends to be really error-prone, since one is often not noticing if lines are shifting and this tends to get a constant re-hunting for correct documentation.
Then it's better to just keep static, will re-put the plain code here and push, branch needs an update anyhow.
There was a problem hiding this comment.
Update: ah, ok, I see the problem that the examples - if self-contained seem to get really long, also this makes use of this inclusion pretty heavily, a bit of a pity to reverse.
Then I won't do, but we should keep in mind a bit and be really careful here.
There was a problem hiding this comment.
Have pushed an update building the examples and do some small adjustments. Will approve/merge when CI passes. Thanks for the PR! 🙂
examplesdirectory.npm run examples:buildnpm run examplesscripts in package.json