Change usages of equals to strictEquals#4036
Merged
Merged
Conversation
…to equals-to-strict-equals
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
am1r021
force-pushed
the
equals-to-strict-equals
branch
from
c47c856 to
ddccd77
Compare
jochem-brouwer
approved these changes
Apr 28, 2025
jochem-brouwer
left a comment
jochem-brouwer
left a comment
Member
There was a problem hiding this comment.
Fixed a merge conflict, also checked the files, LGTM 🎉 Merge if CI passes! 😄 👍
Member
|
Ok, think we can take this in, no release interference here. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4002 by replacing
assert.equalswith assert.strictEquals`.