Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: adjust test runner with verkle state management #3716

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

gabrocheleau
Copy link
Contributor

This PR improves the test runner so that a stateManager option can be passed in order to use a non-default (default being MerkleStateManager) state manager (for now, the only other option is stateManager=verkle, which will instantiate a StatefulVerkleStateManager to run the requested tests.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.99%. Comparing base (5660e21) to head (2f76957).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.25% <ø> (ø)
client 0.00% <ø> (ø)
common 89.93% <100.00%> (+0.04%) ⬆️
devp2p 71.95% <ø> (ø)
evm 64.90% <100.00%> (+<0.01%) ⬆️
genesis 100.00% <ø> (ø)
mpt 52.09% <ø> (-0.11%) ⬇️
statemanager 68.91% <0.00%> (+0.04%) ⬆️
tx 76.70% <ø> (ø)
util 72.78% <ø> (ø)
vm 57.37% <100.00%> (ø)
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

What is the status of this?

@acolytec3
Copy link
Contributor

I'm still using it to try and run the verkle test fixtures but it's not ready for merging. We still have some blockers when running verkle at genesis that I don't have a solution for. Notably, if verkle is at genesis, we have to figure out how to hack in an execution witness or else relax the requirements for creating verkle blocks. I have ideas but none are really elegant or don't introduce tech debt we don't want

@acolytec3
Copy link
Contributor

acolytec3 commented Oct 28, 2024

We need to merge 91d3dd3 and 0e9f438 to master and c61cf3d and 3d86e4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants