Repository navigation
client: Subsume engine's INVALID_TERMINAL_BLOCK into INVALID response - #1919
Merged
Merged
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
changed the title
g11tech
changed the title
INVALID_TERMINAL_BLOCK into INVALID response
g11tech
changed the title
INVALID_TERMINAL_BLOCK into INVALID responseINVALID_TERMINAL_BLOCK into INVALID response
g11tech
changed the title
INVALID_TERMINAL_BLOCK into INVALID response
ryanio
reviewed
May 27, 2022
| status: Status.INVALID, | ||
| validationError: null, | ||
| latestValidHash: null, | ||
| latestValidHash: ZERO_VALID_HASH, |
Contributor
There was a problem hiding this comment.
thanks for opening! looks great. just thinking, could you instead use bufferToHex(zeroes(32))? don't think we need an extra constant really.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ethereum/execution-apis#217 part of the v1.0.0-alpha.9 subsumes the INVALID_TERMINAL_BLOCK into INVALID response via {status: INVALID, latestValidHash: 0x0000000000000000000000000000000000000000000000000000000000000000}
This PR implements the same.