New VM v5.3.2 Release#1199
Merged
Merged
Conversation
…, updated upstream dependencies
holgerd77
requested review from
alcuadrado,
cgewecke,
jochem-brouwer and
ryanio
Member
Author
|
Very little time today, so I would just publish on npm once approved and do all the rest tomorrow morning. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
alcuadrado
approved these changes
Apr 12, 2021
|
|
||
| ## 5.3.2 - 2021-04-12 | ||
|
|
||
| This is a hot-fix performance release, removing the `debug` functionality from PR [#1080](https://github.com/ethereumjs/ethereumjs-monorepo/pull/1080) and follow-up PRs. While highly useful for debugging, this feature side-introduced a siginficant reduction in VM performance which went along unnoticed. For now we will remove since upstream dependencies are awaiting a new release before the `Belin` HF happening. We will try to re-introduce in a performance friendly manner in some subsequent release (we cannot promise on that though). |
Member
There was a problem hiding this comment.
Suggested change
| This is a hot-fix performance release, removing the `debug` functionality from PR [#1080](https://github.com/ethereumjs/ethereumjs-monorepo/pull/1080) and follow-up PRs. While highly useful for debugging, this feature side-introduced a siginficant reduction in VM performance which went along unnoticed. For now we will remove since upstream dependencies are awaiting a new release before the `Belin` HF happening. We will try to re-introduce in a performance friendly manner in some subsequent release (we cannot promise on that though). | |
| This is a hot-fix performance release, removing the `debug` functionality from PR [#1080](https://github.com/ethereumjs/ethereumjs-monorepo/pull/1080) and follow-up PRs. While highly useful for debugging, this feature side-introduced a siginficant reduction in VM performance which went along unnoticed. For now we will remove since upstream dependencies are awaiting a new release before the `Belin` HF happening. We will try to re-introduce in a performance friendly manner in some subsequent release (we cannot promise on that though). The `step` event output is now also changed, with some elements not available anymore (they can be calculated on demand, though). |
Member
There was a problem hiding this comment.
Step event also changed.
Member
There was a problem hiding this comment.
Which ones? That's not intended.
Member
There was a problem hiding this comment.
Just checked this again, and this is not the case. I didn't modify the code that creates eventObj, the object is not modified later, and is the only thing passed to the event listeners.
Member
Author
|
@jochem-brouwer sorry, don't have time to wait for CI another round, so will merge as-is. Have published on npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.