Make genesis params settable for any hardfork in block headers #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
changed the title
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Mar 17, 2021
|
On thinking about this I have the impression this restriction is just plain wrong and is rather a bug fix. I hadn't it on the radar that several hardforks can be applied together on one block with the special case of this happening on the genesis block (as it is the case for So seems to safe to me to merge "as is". |
|
(also recently had to fix some similar - or at least somewhat related bug - on some hardfork determination logic in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR removes a restriction introduced in #863 that disallows commons with custom genesis settings unless their hardforks are set to
chainstart.This is blocking integration of the
blockmodule in the Hardhat testrpc because they set a custom common with special gas limits, chainId, etc as an initial step on launch, but need to run on arbitrary hardforks.https://github.com/nomiclabs/hardhat/blob/579d44a105d6a8323d270ea55876c6694c212316/packages/hardhat-core/src/internal/hardhat-network/provider/utils/makeCommon.ts#L20-L42
Perhaps this restriction should be preserved but gated behind a flag - not sure. Am opening in the simplest form for further discussion.