Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

More logger improvements #75

Merged
merged 5 commits into from
Jun 3, 2020
Merged

More logger improvements #75

merged 5 commits into from
Jun 3, 2020

Conversation

holgerd77
Copy link
Member

@holgerd77 holgerd77 commented Jun 3, 2020

Some more logger improvements:

  1. Added number of peers to refillConnections() debug message
  2. Replaced try/catch logic for EIP-8 auth check to avoid side-effects and get rid of misleading wrong-ecies-header debug output
  3. Moved debug output in BanList.add() after the set operation to get the correct size output
  4. Added debug message for DISCONNECT reason from peer (this was always some constant re-debug reason, and at the end it's mostly TOO_MANY_PEERS)

Number 2. gets rid of these constant errors which always caused irritation and triggers some unnecessary debugging:

  devp2p:rlpx:peer Received body 191.234.162.198:30303 01c104 +1ms
  devp2p:rlpx:peer Received DISCONNECT (message code: 1 - 0 = 1) 191.234.162.198:30303 +0ms
  devp2p:rlpx refill connections.. queue size: 0, peers: 3, open slots: 22 +1ms
  devp2p:rlpx:peer [ERROR]  wrong ecies header (possible cause: EIP8 upgrade): 01 / 04 +142ms
  devp2p:rlpx:peer Received ack (EIP8) from 18.138.108.67:30303 +4ms
  devp2p:rlpx:peer Send HELLO to 18.138.108.67:30303 +0ms
  devp2p:rlpx:peer Received header 18.138.108.67:30303 +2ms
  devp2p:rlpx:peer Received body 18.138.108.67:30303 01c104 +1ms
  devp2p:rlpx:peer Received DISCONNECT (message code: 1 - 0 = 1) 18.138.108.67:30303 +0ms
  devp2p:rlpx refill connections.. queue size: 0, peers: 2, open slots: 23 +1ms
  devp2p:rlpx:peer [ERROR]  wrong ecies header (possible cause: EIP8 upgrade): 01 / 04 +0ms
  devp2p:rlpx:peer Received ack (EIP8) from 52.187.207.27:30303 +7ms
  devp2p:rlpx:peer Received header 52.187.207.27:30303 +0ms
  devp2p:rlpx:peer Send HELLO to 52.187.207.27:30303 +2ms

Gave this a final test run in the client.

@coveralls
Copy link

coveralls commented Jun 3, 2020

Coverage Status

Coverage decreased (-0.2%) to 87.329% when pulling 58b8211 on logger-improvements into c8cdb44 on master.

Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this looks good

@holgerd77 holgerd77 merged commit d77a3f9 into master Jun 3, 2020
@holgerd77 holgerd77 deleted the logger-improvements branch June 3, 2020 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants