Skip to content

Phoenix Hard-fork to occur at the same block as Aztlan - to "fix it"#261

Merged
sorpaas merged 9 commits into
ethereumclassic:masterfrom
ETCCooperative:atzlan_fix
Jan 27, 2020
Merged

Phoenix Hard-fork to occur at the same block as Aztlan - to "fix it"#261
sorpaas merged 9 commits into
ethereumclassic:masterfrom
ETCCooperative:atzlan_fix

Conversation

@bobsummerwill
Copy link
Copy Markdown
Member

No description provided.

@bobsummerwill bobsummerwill self-assigned this Jan 19, 2020
…an was set, and link to Wei's recommendations on "Atzlan fix".
Copy link
Copy Markdown
Contributor

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this ECIP is merge-able, I want to point out that there is not enough time to implement Aztlan-fix on the same block as Aztlan. We've just had several design flaws in ECIP-1061 because the proper ECIP process was bypassed, and also because there were not sufficient time for reviews. Phoenix definitely needs to learn those lessons from Aztlan and give sufficient time for reviews and testing.

Also a small note that this together with #263 is conflicting with #221 vs #224, but this won't be an issue with the current active ECIP process.

Comment thread _specs/ecip-aztlan-fix.md Outdated
@bobsummerwill
Copy link
Copy Markdown
Member Author

ECIP Editors: @soc1c @YazzyYaz @meowsbits @sorpaas @BelfordZ:
Please can you review/comment/merge? I think this is ready to go. Thanks!

Comment thread _specs/ecip-1078.md
@bobsummerwill
Copy link
Copy Markdown
Member Author

@sorpaas Is this blocked from merging purely on your review? Please can you unblock and merge please? Thank you.

…m earlier ECIP.

The language was inappropriate in this example.
@bobsummerwill
Copy link
Copy Markdown
Member Author

@sorpaas Copyright language corrected. This good now?

@soc1c soc1c added this to the Aztlán Hardfork milestone Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants