Replace SHA3 opcode with KECCAK256#825
Merged
yperbasis merged 1 commit intoethereum:masterfrom Nov 26, 2021
Merged
Conversation
Member
|
Looks good. |
yperbasis
approved these changes
Nov 26, 2021
ethosdev
added a commit
to ethosdev/ethereum-org-website
that referenced
this pull request
Sep 16, 2022
ethosdev
added a commit
to ethosdev/ethereumjs-monorepo
that referenced
this pull request
Sep 28, 2022
fulldecent
pushed a commit
to fulldecent/yellowpaper
that referenced
this pull request
Dec 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was proposed in 2016, Solidity uses this since 2017, and evmone and some other VMs use the
keccak256name.However since this was never updated in the Yellow Paper, notably geth (+ erigon) and nethermind still use the
sha3name.A similar renaming took place from
suicidetoselfdestructwhich is the term Yellow Paper uses (and no reference is kept tosuicide). I think thekeccak256is more expressive, and given the previous case this renaming likely won't cause much harm.