Fix minGasLimit to 5000 #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksavers
changed the base branch from
CALL-does-not-increase-gas
to
master
|
You may want to add |
|
I noticed another occurrence that I missed Edit: Fixed in 72cc52e |
nicksavers
added a commit
that referenced
this pull request
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix according to #317
Major clients implement a minGasLimit of 5000 instead of 125000 as specified in the paper
https://github.com/ethereum/go-ethereum/blob/master/params/protocol_params.go#L76
https://github.com/ethereum/cpp-ethereum/blob/develop/libethereum/GenesisInfo.cpp#L36
https://github.com/paritytech/parity/blob/master/ethcore/res/ethereum/foundation.json#L147
https://github.com/ethereum/ethereumj/blob/develop/ethereumj-core/src/main/java/org/ethereum/config/blockchain/FrontierConfig.java#L44