Encode block_count as hex in eth_feeHistory RPC#2117
Conversation
|
Looks like the CI uses Geth 1.10.6 which doesn't support block count as hex. This was fixed in the 1.10.7 release (relevant PR). I guess we'll have to wait till this py-geth PR gets merged. |
Thanks for this. We'll try to get this py-geth version bump in asap. Also, please note that geth version 1.10.8 is the one to use post-London since it includes a hotfix for a security vulnerability. Any other version post-London is susceptible to this vulnerability. Figured I'd reiterate this here; couldn't hurt. |
647feb5 to
a5ce8c6
Compare
|
@shuklaayush merged! Thanks again for jumping on this before the py-geth PR was even merged. |
What was wrong?
eth_feeHistoryRPC call was sendingblock_countas a raw integer instead of hex. This broke hardhat since it expects QUANTITIES (integers etc.) to be hex-encodedHow was it fixed?
Modified
eth_feeHistoryformatter to encodeblock_countas hex before making the RPC callTodo:
Cute Animal Picture