CREATE/CREATE2 a contract with all possible first bytes#843
Merged
winsvega merged 2 commits intoethereum:developfrom May 14, 2021
Merged
CREATE/CREATE2 a contract with all possible first bytes#843winsvega merged 2 commits intoethereum:developfrom
winsvega merged 2 commits intoethereum:developfrom
Conversation
winsvega
reviewed
May 12, 2021
| network: | ||
| - 'Berlin' | ||
| result: | ||
| a94f5374fce5edbc8e2a8697c15331677e6ebf0b: |
There was a problem hiding this comment.
can add a few addresses with deployed code here to show and to see that accounts with that bytecode has actually been deployed
winsvega
reviewed
May 12, 2021
| code: | | ||
| :yul | ||
| { | ||
| // { mstore8(0, 0x00) return(0, 1) } |
There was a problem hiding this comment.
this is the contract constructor code.
so you need actually to return the bytecode of a contract that is being created. here it is 0x00
or do you try to create2 a contract with constructor code with invalid code before return?
Member
Author
There was a problem hiding this comment.
Yes, intention is to create contracts with code that consists of one byre
Member
Author
There was a problem hiding this comment.
Added some comments in yul code.
gumb0
force-pushed
the
deploy-invalid-bytes
branch
from
f738c6d to
21d4d75
Compare
gumb0
force-pushed
the
deploy-invalid-bytes
branch
from
21d4d75 to
bdc88a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #835 removing London expectations, should be useful on its own to check that deploying all undefined bytes is allowed in Berlin.